<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102245/">http://git.reviewboard.kde.org/r/102245/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 16th, 2011, 3:29 p.m., <b>Laszlo Papp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Mmm, I stopped marking the game* -> project* renaming after a while (it is no a bit mixed), so I might have missed something. If you would not like to do that renaming in this patch, that is fine. I can also do it later. That is not a biggie. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I won't include the name changes in gameviewitem (game->project and some more), as I don't think they belong in this patch. I don't think it's a good idea to change api somewhere hidden in a patch about something completely different. So I'd vote for doing these changes in another commit.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 16th, 2011, 3:29 p.m., <b>Laszlo Papp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102245/diff/3/?file=31242#file31242line87" style="color: black; font-weight: bold; text-decoration: underline;">player/lib/models/gameviewitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString GameViewItem::projectDirName() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">74</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QString</span> <span class="n">GameViewItem</span><span class="o">::</span><span class="n">projectDirName</span><span class="p">()</span> <span class="k">const</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">79</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QString</span> <span class="n">GameViewItem</span><span class="o">::</span><span class="n">projectDirName</span><span class="p">()</span> <span class="k">const</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why not just projectDir term ? projectDirName reminds me that it is just the *.gluon bundle name, and not the path.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">$ git blame -L66 player/lib/models/gameviewitem.h:
2813c421 (Laszlo Papp 2011-03-27 17:05:28 +0300 66) QString projectDirName() const;
;)
</pre>
<br />
<p>- Felix</p>
<br />
<p>On August 9th, 2011, 9:02 a.m., Felix Rohrbach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gluon.</div>
<div>By Felix Rohrbach.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2011, 9:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now, the user should be able to create games with simple statistics/achievements.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>player/lib/models/commentsmodel.cpp <span style="color: grey">(4572f23)</span></li>
<li>player/lib/models/gameitemsmodel.h <span style="color: grey">(d2e3604)</span></li>
<li>player/lib/models/gameitemsmodel.cpp <span style="color: grey">(c4c977c)</span></li>
<li>player/lib/models/gameviewitem.h <span style="color: grey">(a017862)</span></li>
<li>engine/gameproject.cpp <span style="color: grey">(1fc2eb4)</span></li>
<li>player/kdeext/gamedetailsoverlay.h <span style="color: grey">(99923a2)</span></li>
<li>player/kdeext/gamedetailsoverlay.cpp <span style="color: grey">(b6f525c)</span></li>
<li>player/kdeext/gamesoverlay.cpp <span style="color: grey">(d468186)</span></li>
<li>player/lib/models/achievementsmodel.h <span style="color: grey">(3df946e)</span></li>
<li>player/lib/models/achievementsmodel.cpp <span style="color: grey">(e1ebad0)</span></li>
<li>engine/game.cpp <span style="color: grey">(9495909)</span></li>
<li>player/lib/models/gameviewitem.cpp <span style="color: grey">(64dd46a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102245/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>