Multiplication_tables activity Review

[JAZEIX Johnny]

Hi Nitish,

I did remarks in https://phabricator.kde.org/D4982 even if it's not 
related to this diff.

There are still issues with resizing.

Johnny

On 03/19/17 18:38, nitish chauhan wrote:
> Hi,
> here is the link for review of the activity:-
> https://cgit.kde.org/gcompris.git/commit/?h=sok_nitishc_multiplicationtables&id=d428752b612c0bf2e3aed5999510e88be9aa2efd 
>
>
> changes made :-
> 1.) default value for the configuration is fixed. 2.) save/load of the 
> configuration is working for the activity.
> 3.) Name of the modes are changed to *_default questions_ (earlier 
> normal mode)* & *_choose questions_ (earlier school mode).*
> 4.) Flickable(scroll) mode is implemented for school mode so that many 
> questions can be chosen without breaking the UI. 5.) Name of the 
> activity is to be changed as suggested by Emmanuel (I need some 
> suggestions here)
> 6.) code cleanup is done.
>
> please share your review & feedback. regards, Nitish Chauhan


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gcompris-devel/attachments/20170417/67aaa5d6/attachment.html>