<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Nitish,<br>
<br>
I did remarks in <a class="moz-txt-link-freetext" href="https://phabricator.kde.org/D4982">https://phabricator.kde.org/D4982</a> even if it's
not related to this diff.<br>
<br>
There are still issues with resizing.<br>
<br>
Johnny<br>
<br>
On 03/19/17 18:38, nitish chauhan wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAGfTHWNYNqb4UqVOXasyipT+jSgBT1GdBsNg1Mt_Ac=STfw2QA@mail.gmail.com">
<div dir="ltr">Hi,<br>
here is the link for review of the activity:-
<div><a
href="https://cgit.kde.org/gcompris.git/commit/?h=sok_nitishc_multiplicationtables&id=d428752b612c0bf2e3aed5999510e88be9aa2efd"
moz-do-not-send="true">https://cgit.kde.org/gcompris.git/commit/?h=sok_nitishc_multiplicationtables&id=d428752b612c0bf2e3aed5999510e88be9aa2efd</a>
<div><br>
</div>
<div>changes made :-</div>
<div>1.) <span style="color:rgb(0,0,0);white-space:pre-wrap">default value for the configuration is fixed.
2.) </span><span style="color:rgb(0,0,0);white-space:pre-wrap">save/load of the configuration is working for the activity.</span></div>
<div><span style="color:rgb(0,0,0);white-space:pre-wrap">3.) Name of the modes are changed to <b><u>default questions</u> (earlier normal mode)</b> & <b><u>choose questions</u> (earlier school mode).</b></span></div>
<div><span style="color:rgb(0,0,0);white-space:pre-wrap">4.) Flickable(scroll) mode is implemented for </span><font
color="#000000"><span style="white-space:pre-wrap">school mode so that many questions can be chosen without breaking the UI.
</span></font><span style="color:rgb(0,0,0);white-space:pre-wrap">5.) Name of the activity is to be changed as suggested by Emmanuel (I need some suggestions here)</span></div>
<div><span style="color:rgb(0,0,0);white-space:pre-wrap">6.) code cleanup is done.</span></div>
<div><br>
</div>
<div><span style="color:rgb(0,0,0);white-space:pre-wrap">please share your review & feedback.
regards,
Nitish Chauhan</span></div>
<div><span style="color:rgb(0,0,0);white-space:pre-wrap"> </span></div>
</div>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>