[GCompris-devel] Search feature

[Emmanuel Charruau]

We could keep the same button size but just resize the search icon and
putting it a bit on the top right?

2016-07-19 21:05 GMT+02:00 JAZEIX Johnny <jazeix at gmail.com>:

> Hi,
>
> for now the search icon is part of the section bar.
>
> If we reduce it, it may be too small in portrait mode (the other icons are
> already small) or on tablet?
>
> I found a little bug: if you type a search (to filter activities), go to
> the config, press the close button, the  text filter is there but all the
> activities also (not only the filtered ones). If you press Escape, you have
> the text but only the filtered activities.
> I displayed 'activity.inputText' in DialogActivityConfig.onClose and it is
> empty (tested with bith Qt5.5.1 and Qt5.7.0).
>
> Also, if virtual keyboard is visible and you resize the screen width (it
> works fine for the height), it disappears.
>
> Except these two issues, the code is clean for me :).
>
> Johnny
>
>
> On 07/19/16 13:44, Emmanuel Charruau wrote:
>
> Hi Rishab,
> I tested using words like multiplication color weight line etc.
> Used virtual and real keyboard.
> Everything is working for me.
> I would have a design proposition.
> Could we not make the search icon a bit smaller to detach it a bit from
> the sections icons?
> I did a mockup to show you.
>
> Emmanuel
>
> 2016-07-17 19:55 GMT+02:00 RISHABH GUPTA <rishabh9511 at gmail.com>:
>
>> Hello all,
>>
>> After a lot of days I got time to work on the search feature . The things
>> that were previously left undone are now mostly done.A lot of things have
>> been fixed.I have created a new pull request for the same.So,please review
>> the changes and kindly make suggestions for things that you feel are wrong
>> or are buggy.
>>
>> Here's the link of the pull request
>> https://github.com/gcompris/GCompris-qt/pull/151
>>
>> Let's get the search feature out \m/
>> Thanks ,
>> Rishabh
>>
>> _______________________________________________
>> GCompris-devel mailing list
>> GCompris-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/gcompris-devel
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gcompris-devel/attachments/20160719/3d14269c/attachment.html>