D14513: Add QML Extensions API

Anmol Gautam noreply at phabricator.kde.org
Sat Aug 11 17:21:20 BST 2018


anmolgautam added inline comments.

INLINE COMMENTS

> drosca wrote in qmlextensionscheme.cpp:31
> Tried how? Did you change the code so it just calls `qmlEngine(this)->newQObject(request);` and then checked if that object gets correctly garbage collected by engine (deleted)?

connect(m_schemeHandler, &QmlExtensionSchemeHandler::_requestStarted, this, [this](QWebEngineUrlRequestJob *job) {
          QmlWebEngineUrlRequestJob *request = new QmlWebEngineUrlRequestJob(job);
          emit requestStarted(qmlEngine(this)->newQObject(request));
      });

Or did you meant the snippet which I send in previous comment?

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14513

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180811/8f2241e3/attachment.html>


More information about the Falkon mailing list