D14513: Add QML Extensions API

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> anmolgautam wrote in qmlextensionscheme.cpp:31
> Yes I tried. But `qmlEngine(this)->newQObject(request);` returns QJSValue - so its need to be changed to  the signal paramater

Tried how? Did you change the code so it just calls `qmlEngine(this)->newQObject(request);` and then checked if that object gets correctly garbage collected by engine (deleted)?

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14513

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180811/bd5aa6a3/attachment.html>