D14513: Add QML Extensions API

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> anmolgautam wrote in qmlextensionscheme.cpp:31
>   connect(m_schemeHandler, &QmlExtensionSchemeHandler::_requestStarted, this, [this](QWebEngineUrlRequestJob *job) {
>           QmlWebEngineUrlRequestJob *request = new QmlWebEngineUrlRequestJob(job);
>           emit requestStarted(qmlEngine(this)->newQObject(request));
>       });
> 
> Or did you meant the snippet which I send in previous comment?

I meant what I told you to do, just call `qmlEngine(this)->newQObject(request);`

  connect(m_schemeHandler, &QmlExtensionSchemeHandler::_requestStarted, this, [this](QWebEngineUrlRequestJob *job) {
      QmlWebEngineUrlRequestJob *request = new QmlWebEngineUrlRequestJob(job);
      qmlEngine(this)->newQObject(request);
      emit requestStarted(request);
  });

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14513

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180811/69c109b7/attachment.html>