D14513: Add QML Extensions API

[Anmol Gautam]

anmolgautam added inline comments.

INLINE COMMENTS

> drosca wrote in qmlextensionscheme.cpp:31
> You can still use the QmlWebEngineUrlRequestJob pointer in signal, not QJSValue.

Then it needs to make the jsvalue return of engine->newQObject as unused? something like -
QmlWebEngineUrlRequestJob *request = new QmlWebEngineUrlRequestJob(job);
auto jsval = qmlEngine(this)->newQObject(request);
emit requestStarted(request);
?

> drosca wrote in qmli18n.cpp:26
> And is that really needed?
> I'd like to see explicitly choosing which language to load here.

You mean something like Falkon.I18n.setLocale() on qml side?

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14513

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180811/a19fa98d/attachment.html>