D14513: Add QML Extensions API

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> anmolgautam wrote in qmlextensionscheme.cpp:31
> Then it needs to make the jsvalue return of engine->newQObject as unused? something like -
> QmlWebEngineUrlRequestJob *request = new QmlWebEngineUrlRequestJob(job);
> auto jsval = qmlEngine(this)->newQObject(request);
> emit requestStarted(request);
> ?

No, just calling `qmlEngine(this)->newQObject(request);` should be enough.

Did you actually try it?

> anmolgautam wrote in qmli18n.cpp:26
> You mean something like Falkon.I18n.setLocale() on qml side?

No, on the cpp side so when/if there is a support for switching languages it is easy to implement.

Also translations functions should be added to global namespace, so they are accessible with just `i18n`/`i18np` without Falkon namespace.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14513

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180811/e9054440/attachment.html>