Packaging and License feedback

[Matthieu Gallien]

Hello Aurélien,

On vendredi 14 septembre 2018 00:05:27 CEST Coucouf wrote:
> Le 05/09/2018 à 17:59, Matthieu Gallien a écrit :
> …
> 
> > I will try to fix the other issues during the feature freeze for the next
> > stable version.
> 
> Hi Matthieu,
> 
> I just received the commit notifications for the license headers and moving
> the the private library, so thanks !
> Actually I had started working on mergeable branches of these changes to so
> I’m sharing them here.

Hello, I only noticed the gitlab instance you were using after the fact. Sorry 
for that.

> Regarding the license headers I was in fact doing the same in parallel but
> have more files in my diff than you do (163 vs. 155).
> It may well be du to the commits that landed since I branch but you may
> still want to have a look at [1].
> At least src/qml/PassiveNotification.qml has a slightly different header is
> definitely missing the fix.

Yes, this file and maybe some others are coming from other projects and thus 
are under LGPL v2+ that is compatible with the license of Elisa as a whole.

> Also you may be interested in [2] which is a small diff for a typo raised by
> lintian.
> « allow to » is not really correct in English since you’re supposed allow
> _someone_ to do something.

I have created a review with your fix.
Thanks

> 
> [1]
> https://framagit.org/Coucouf/elisa/commit/cdf55a68e0b5f52e795c278cf41747c6c
> 6891a83 [2]
> https://framagit.org/Coucouf/elisa/commit/f2d4ef7a0b23e440da1701fa488733642
> 8fe898a
> 
> 
> Cheers,
> --
> Aurélien

Please let me know if there are other issues preventing proper inclusion in 
Debian.

Best regards

--
Matthieu Gallien