Packaging and License feedback

Coucouf coucouf at coucouf.fr
Thu Sep 13 23:05:27 BST 2018


Le 05/09/2018 à 17:59, Matthieu Gallien a écrit :
…
> I will try to fix the other issues during the feature freeze for the next 
> stable version.

Hi Matthieu,

I just received the commit notifications for the license headers and moving the
the private library, so thanks !
Actually I had started working on mergeable branches of these changes to so I’m
sharing them here.

Regarding the license headers I was in fact doing the same in parallel but have
more files in my diff than you do (163 vs. 155).
It may well be du to the commits that landed since I branch but you may still
want to have a look at [1].
At least src/qml/PassiveNotification.qml has a slightly different header is
definitely missing the fix.

Also you may be interested in [2] which is a small diff for a typo raised by
lintian.
« allow to » is not really correct in English since you’re supposed allow
_someone_ to do something.


[1] https://framagit.org/Coucouf/elisa/commit/cdf55a68e0b5f52e795c278cf41747c6c6891a83
[2] https://framagit.org/Coucouf/elisa/commit/f2d4ef7a0b23e440da1701fa4887336428fe898a


Cheers,
--
Aurélien


More information about the Elisa mailing list