New dependency for KPat

[Jonathan Riddell]

On Wed, May 16, 2018 at 07:21:29PM +0200, Fabian K. wrote:
> there is currently a patch under review which improves the solver for 2 of the
> supported games. However, it would add a new dependency on the freecell-solver
> library from http://fc-solve.shlomifish.org/. As far as I can tell, there is
> already a package available in Debian, and there is a RPM, though that one is
> not available in all RPM based distros.
> 
> We'd like to add the library as a hard dependency, but before doing so we'd
> like to know if that would pose issues for any distribution.

Compiling master with libfreecell-solver-dev installed and /usr/lib/pkgconfig/libfreecell-solver.pc present I get

https://build.neon.kde.org/job/xenial_unstable_kde_kpat_bin_amd64/78/console
13:31:33 -- Checking for modules 'libfreecell-solver;IMPORTED_TARGET'
13:31:33 --   No package 'IMPORTED_TARGET' found

If I remove IMPORTED_TARGET from CMakeLists.txt it compiles until the end when it errors with:
[100%] Linking CXX executable kpat
/usr/bin/ld: cannot find -lPkgConfig::FC_SOLVE

changing CMakeLists.txt with
-    PkgConfig::FC_SOLVE
+    ${FC_SOLVE_LDFLAGS}

It successfully compiles and when installed with kdegames-card-data-kf5 it runs nicely

Jonathan