[Digikam-users] More questions about sort order in folders

[Arnd Baecker]

Hi Chris,

On Thu, 10 Jul 2008, Chris G wrote:

> On Thu, Jul 10, 2008 at 03:53:10AM +0200, Arnd Baecker wrote:
> > > Is this change of general interest or shall I just keep it as a
> > > private patch which I apply for my own use only?
> >
> > As far as I can say this is clearly of general interest.
> >
> > Could you attach your current patch at
> > https://bugs.kde.org/show_bug.cgi?id=156186
> > as it addresses the first part of the wish there?
> > At this point the patch need not be polished etc.,
> > but I (and others) can have a look at it.
> >
> I have submitted my patch to bugzilla as above, I've just listed it
> out as a comment rather than a patch/diff, hope that's OK.  For future
> reference is there anywhere that gives a quick description of how to
> submit a patch as an attachment?  (Remember I'm a died-in-the-wool
> Solaris developer, not used to these new-fangled modern Linux systems!).

;-)

Well, its still cooking with water, though sometimes
some weird modern spices are thrown to make things look shiny ...

To get a good diff there are two options:

a) # copy the un-modified file

   cp albumfolderview.cpp albumfolderview.cpp_orig
   # make your changes, compile, install and test

   # then do the diff:
   diff -u albumfolderview.cpp_orig albumfolderview.cpp  >  p156186v1.patch

b) much more convient and recommended is to use an svn check-out:
   See http://www.digikam.org/drupal/download?q=download/svn
   under "Install digiKam for KDE3 in your Home Directory"

   The advantage of that installation procedure is
   that it is completely independent from you system installation
   and can be "turned on/off" just by setting (or not setting)
   the corresponding environment variables.

   Note that in the past there were some problems
   when several exiv2 versions are installed; if we are lucky
   this has been solved yesterday by Gilles.

   To create a diff:
     svn diff >  p156186v1.patch

   To revert a patch:
     patch -R < p156186v1.patch

   I usually issue the svn diff command on the graphics level.
   (Not sure if this is optimal or not).

   Sometimes, when applying patches via
      patch -p0 < p156186v1.patch
   the additional "-p0" option is needed.

  Before updating from svn via
    svn up
  it is recommended to un-apply all patches, so that
    svn diff
  does not show any differences.
  Otherwise it might happen that there are conflicts, which one
  then has to correct by hand.
  I.e. I prefer to unapply all patches, do `svn up` and
  then apply the patches again. This seems somehow more controlled to me.

Finally, to upload the patch to the bug tracker (BKO),
just use the "Create a New Attachment" near the bottom of the page
(might be only visible if you are logged in).

Hope this helps, and don't hesitate to ask!

Best, Arnd

P.S.: And now I will try your patch ... ;-)