[Digikam-devel] Review Request 109298: Adding photo informations to the album view item

Gilles Caulier caulier.gilles at gmail.com
Wed Mar 13 09:26:03 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109298/#review29116
-----------------------------------------------------------


I tested your last patch, and you miss-understood me.

Previously, i talk about Preview mode (from Album UI, press F3). Preview is not thumbnail. It a real view of image to replace icon view. It's not a real full image handling as it's done in image editor. A reduced size of image data is used to speed up loading.

Your new patch include thumbnail overlay support. I not sure if it's the right way to do. We have already tool tip for this purpose. Also, do you see that a new View Mode have been introduced recently : Table-view. To switch on, go to View menu and select right option. In this mode, you can customize items info columns visible, including photo info.

But Preview Mode need definitively photo info overlay. Just to be sure that you understand what i mean, i take a shot of preview mode :

http://www.flickr.com/photos/digikam/8554418954/

Overlay need to be displayed on the bottom/left corner of preview canvas...

Gilles Caulier




- Gilles Caulier


On March 12, 2013, 11:10 p.m., Marco Berghoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109298/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 11:10 p.m.)
> 
> 
> Review request for Digikam and Gilles Caulier.
> 
> 
> Description
> -------
> 
> This patch adds a line with informations about aperture, exposure time, ISO sensitivity and focal length between filename and title. It looks like "F7.1 1/900s ISO 200 8mm".
> 
> A checkbox for switching this line on/off is added to the albumview setup dialog.
> 
> 
> Diffs
> -----
> 
>   utilities/setup/setupalbumview.cpp f2d5e7c 
>   utilities/importui/views/importsettings.cpp 0175079 
>   utilities/importui/views/importsettings.h 1c3274e 
>   libs/widgets/itemview/itemviewimagedelegatepriv.h 8735e6a 
>   libs/widgets/itemview/itemviewimagedelegate.cpp 1a1632c 
>   libs/widgets/itemview/itemviewimagedelegate.h d1c3fd0 
>   digikam/utils/albumsettings.h 501213a 
>   digikam/utils/albumsettings.cpp b838479 
>   digikam/main/digikamui.rc f410ad7 
>   digikam/main/digikamapp_p.h 2d9f0c2 
>   digikam/main/digikamapp.cpp 290840f 
>   digikam/items/imagethumbnaildelegate.cpp d34b21e 
>   digikam/main/digikamapp.h 0286bce 
>   digikam/items/imagedelegatepriv.h 0ffa233 
>   digikam/items/imagedelegate.cpp 6dfad4f 
>   digikam/items/digikamimagedelegate.cpp 3e65a85 
> 
> Diff: http://git.reviewboard.kde.org/r/109298/diff/
> 
> 
> Testing
> -------
> 
> Compiles fine.
> Albumview items have the infoline if the checkmark is set in the setup dialog and hide it if not.
> 
> 
> Thanks,
> 
> Marco Berghoff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130313/d7d118e5/attachment.html>


More information about the Digikam-devel mailing list