[Digikam-devel] Review Request 109298: Adding photo informations to the album view item

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109298/#review29118
-----------------------------------------------------------


Thumbnail Overlay mode is really a bad idea. It bloat GUI, as expected :

http://www.flickr.com/photos/digikam/8553333929/

But this is exactly what we need for preview mode (:=)))...

Please revert you patch to previous version and move/adapt overlay implementation for Preview Mode. Classes dedicated to show preview in Album UI and Light Table canvas are listed below:

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/widgets/graphicsview/graphicsdimgview.h

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/views/imagepreviewview.h

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/lighttable/lighttablepreview.h

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/importui/views/importpreviewview.h

Gilles Caulier



- Gilles Caulier


On March 12, 2013, 11:10 p.m., Marco Berghoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109298/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 11:10 p.m.)
> 
> 
> Review request for Digikam and Gilles Caulier.
> 
> 
> Description
> -------
> 
> This patch adds a line with informations about aperture, exposure time, ISO sensitivity and focal length between filename and title. It looks like "F7.1 1/900s ISO 200 8mm".
> 
> A checkbox for switching this line on/off is added to the albumview setup dialog.
> 
> 
> Diffs
> -----
> 
>   utilities/setup/setupalbumview.cpp f2d5e7c 
>   utilities/importui/views/importsettings.cpp 0175079 
>   utilities/importui/views/importsettings.h 1c3274e 
>   libs/widgets/itemview/itemviewimagedelegatepriv.h 8735e6a 
>   libs/widgets/itemview/itemviewimagedelegate.cpp 1a1632c 
>   libs/widgets/itemview/itemviewimagedelegate.h d1c3fd0 
>   digikam/utils/albumsettings.h 501213a 
>   digikam/utils/albumsettings.cpp b838479 
>   digikam/main/digikamui.rc f410ad7 
>   digikam/main/digikamapp_p.h 2d9f0c2 
>   digikam/main/digikamapp.cpp 290840f 
>   digikam/items/imagethumbnaildelegate.cpp d34b21e 
>   digikam/main/digikamapp.h 0286bce 
>   digikam/items/imagedelegatepriv.h 0ffa233 
>   digikam/items/imagedelegate.cpp 6dfad4f 
>   digikam/items/digikamimagedelegate.cpp 3e65a85 
> 
> Diff: http://git.reviewboard.kde.org/r/109298/diff/
> 
> 
> Testing
> -------
> 
> Compiles fine.
> Albumview items have the infoline if the checkmark is set in the setup dialog and hide it if not.
> 
> 
> Thanks,
> 
> Marco Berghoff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130313/4327eced/attachment.html>