<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109298/">http://git.reviewboard.kde.org/r/109298/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested your last patch, and you miss-understood me.
Previously, i talk about Preview mode (from Album UI, press F3). Preview is not thumbnail. It a real view of image to replace icon view. It's not a real full image handling as it's done in image editor. A reduced size of image data is used to speed up loading.
Your new patch include thumbnail overlay support. I not sure if it's the right way to do. We have already tool tip for this purpose. Also, do you see that a new View Mode have been introduced recently : Table-view. To switch on, go to View menu and select right option. In this mode, you can customize items info columns visible, including photo info.
But Preview Mode need definitively photo info overlay. Just to be sure that you understand what i mean, i take a shot of preview mode :
http://www.flickr.com/photos/digikam/8554418954/
Overlay need to be displayed on the bottom/left corner of preview canvas...
Gilles Caulier
</pre>
<br />
<p>- Gilles</p>
<br />
<p>On March 12th, 2013, 11:10 p.m. UTC, Marco Berghoff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Digikam and Gilles Caulier.</div>
<div>By Marco Berghoff.</div>
<p style="color: grey;"><i>Updated March 12, 2013, 11:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a line with informations about aperture, exposure time, ISO sensitivity and focal length between filename and title. It looks like "F7.1 1/900s ISO 200 8mm".
A checkbox for switching this line on/off is added to the albumview setup dialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles fine.
Albumview items have the infoline if the checkmark is set in the setup dialog and hide it if not.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>utilities/setup/setupalbumview.cpp <span style="color: grey">(f2d5e7c)</span></li>
<li>utilities/importui/views/importsettings.cpp <span style="color: grey">(0175079)</span></li>
<li>utilities/importui/views/importsettings.h <span style="color: grey">(1c3274e)</span></li>
<li>libs/widgets/itemview/itemviewimagedelegatepriv.h <span style="color: grey">(8735e6a)</span></li>
<li>libs/widgets/itemview/itemviewimagedelegate.cpp <span style="color: grey">(1a1632c)</span></li>
<li>libs/widgets/itemview/itemviewimagedelegate.h <span style="color: grey">(d1c3fd0)</span></li>
<li>digikam/utils/albumsettings.h <span style="color: grey">(501213a)</span></li>
<li>digikam/utils/albumsettings.cpp <span style="color: grey">(b838479)</span></li>
<li>digikam/main/digikamui.rc <span style="color: grey">(f410ad7)</span></li>
<li>digikam/main/digikamapp_p.h <span style="color: grey">(2d9f0c2)</span></li>
<li>digikam/main/digikamapp.cpp <span style="color: grey">(290840f)</span></li>
<li>digikam/items/imagethumbnaildelegate.cpp <span style="color: grey">(d34b21e)</span></li>
<li>digikam/main/digikamapp.h <span style="color: grey">(0286bce)</span></li>
<li>digikam/items/imagedelegatepriv.h <span style="color: grey">(0ffa233)</span></li>
<li>digikam/items/imagedelegate.cpp <span style="color: grey">(6dfad4f)</span></li>
<li>digikam/items/digikamimagedelegate.cpp <span style="color: grey">(3e65a85)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109298/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>