[Digikam-devel] Review Request 108574: Turned on sorting by pixel size and added sorting by aspect ratio

[Stephen Toothman]

> On Jan. 25, 2013, 10:24 a.m., Gilles Caulier wrote:
> > Right Marcel, the diff is wrong...
> > 
> > Stephen, please checkout digiKam from git/master and make a patch against current implmentation. It's important for us to review and validate your code...
> > 
> > Thanks in advance
> > 
> > Gilles Caulier

I will try to create the diff again.  It is created against the latest version, 3.0.0-rc.  I tried attaching just the local diff I made to port the changes over to the the git branch, but it did not like that.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108574/#review26166
-----------------------------------------------------------


On Jan. 25, 2013, 5:30 p.m., Stephen Toothman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108574/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2013, 5:30 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Description
> -------
> 
> I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  
> 
> 
> This addresses bug none.
>     http://bugs.kde.org/show_bug.cgi?id=none
> 
> 
> Diffs
> -----
> 
>   core/digikam/items/digikamimagedelegate.cpp PRE-CREATION 
>   core/digikam/items/imagedelegate.cpp PRE-CREATION 
>   core/digikam/items/imagedelegatepriv.h PRE-CREATION 
>   core/digikam/main/digikamapp.cpp PRE-CREATION 
>   core/digikam/utils/albumsettings.h PRE-CREATION 
>   core/digikam/utils/albumsettings.cpp PRE-CREATION 
>   core/digikam/utils/tooltipfiller.h PRE-CREATION 
>   core/digikam/utils/tooltipfiller.cpp PRE-CREATION 
>   core/libs/models/imagesortsettings.h PRE-CREATION 
>   core/libs/models/imagesortsettings.cpp PRE-CREATION 
>   core/libs/widgets/itemview/itemviewimagedelegate.h PRE-CREATION 
>   core/libs/widgets/itemview/itemviewimagedelegate.cpp PRE-CREATION 
>   core/utilities/setup/setupalbumview.cpp PRE-CREATION 
>   core/utilities/setup/setuptooltip.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108574/diff/
> 
> 
> Testing
> -------
> 
> I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.
> 
> 
> File Attachments
> ----------------
> 
> local diff I used for porting to the git code base
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/25/core_diff.txt
> 
> 
> Thanks,
> 
> Stephen Toothman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130125/e864888c/attachment.html>