<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108574/">http://git.reviewboard.kde.org/r/108574/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 25th, 2013, 10:24 a.m. UTC, <b>Gilles Caulier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right Marcel, the diff is wrong...
Stephen, please checkout digiKam from git/master and make a patch against current implmentation. It's important for us to review and validate your code...
Thanks in advance
Gilles Caulier</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I will try to create the diff again. It is created against the latest version, 3.0.0-rc. I tried attaching just the local diff I made to port the changes over to the the git branch, but it did not like that.
</pre>
<br />
<p>- Stephen</p>
<br />
<p>On January 25th, 2013, 5:30 p.m. UTC, Stephen Toothman wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Digikam.</div>
<div>By Stephen Toothman.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2013, 5:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator). I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested the functionality and both work as expected. I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=none">none</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/digikam/items/digikamimagedelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/digikam/items/imagedelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/digikam/items/imagedelegatepriv.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/digikam/main/digikamapp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/digikam/utils/albumsettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/digikam/utils/albumsettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/digikam/utils/tooltipfiller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/digikam/utils/tooltipfiller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/libs/models/imagesortsettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/libs/models/imagesortsettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/libs/widgets/itemview/itemviewimagedelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/libs/widgets/itemview/itemviewimagedelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/utilities/setup/setupalbumview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/utilities/setup/setuptooltip.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108574/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/25/core_diff.txt">local diff I used for porting to the git code base</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>