[Digikam-devel] Review Request 108574: Turned on sorting by pixel size and added sorting by aspect ratio

Stephen Toothman stoothman at yahoo.com
Fri Jan 25 17:30:41 GMT 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 25, 2013, 5:30 p.m.)

Review request for Digikam.


Added my original diff I used to add the changes to the git/master branch


I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  

This addresses bug none.


  core/digikam/items/digikamimagedelegate.cpp PRE-CREATION 
  core/digikam/items/imagedelegate.cpp PRE-CREATION 
  core/digikam/items/imagedelegatepriv.h PRE-CREATION 
  core/digikam/main/digikamapp.cpp PRE-CREATION 
  core/digikam/utils/albumsettings.h PRE-CREATION 
  core/digikam/utils/albumsettings.cpp PRE-CREATION 
  core/digikam/utils/tooltipfiller.h PRE-CREATION 
  core/digikam/utils/tooltipfiller.cpp PRE-CREATION 
  core/libs/models/imagesortsettings.h PRE-CREATION 
  core/libs/models/imagesortsettings.cpp PRE-CREATION 
  core/libs/widgets/itemview/itemviewimagedelegate.h PRE-CREATION 
  core/libs/widgets/itemview/itemviewimagedelegate.cpp PRE-CREATION 
  core/utilities/setup/setupalbumview.cpp PRE-CREATION 
  core/utilities/setup/setuptooltip.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/108574/diff/


I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.

File Attachments (updated)

local diff I used for porting to the git code base


Stephen Toothman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130125/c0658538/attachment.html>

More information about the Digikam-devel mailing list