Review Request 120143: Fix bug 338957 / request more than 20 friends
Mehrdad Momeny
mehrdad.momeny at gmail.com
Fri Sep 12 15:48:24 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120143/#review66353
-----------------------------------------------------------
Also please use 4 spaces instead of tab for indentation. (KDE and Choqok coding convention)
BTW, Do you have KDE commit access? (Just want to know)
If not, I can fix this and commit it myself.
helperlibs/twitterapihelper/twitterapidmessagedialog.cpp
<https://git.reviewboard.kde.org/r/120143/#comment46294>
No! need, the duplicates were removed previously!
helperlibs/twitterapihelper/twitterapimicroblog.h
<https://git.reviewboard.kde.org/r/120143/#comment46296>
I don't see the need for this additional list, we can manage it without this.
helperlibs/twitterapihelper/twitterapimicroblog.cpp
<https://git.reviewboard.kde.org/r/120143/#comment46295>
Here! the duplicates (if any) are removed.
- Mehrdad Momeny
On Sept. 11, 2014, 2:22 p.m., Ian Schwarz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120143/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 2:22 p.m.)
>
>
> Review request for Choqok.
>
>
> Repository: choqok
>
>
> Description
> -------
>
> see https://bugs.kde.org/show_bug.cgi?id=338957
>
>
> Diffs
> -----
>
> helperlibs/twitterapihelper/twitterapidmessagedialog.cpp 44ddf5b
> helperlibs/twitterapihelper/twitterapimicroblog.h b9dd97a
> helperlibs/twitterapihelper/twitterapimicroblog.cpp 4fc7ee9
>
> Diff: https://git.reviewboard.kde.org/r/120143/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Schwarz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20140912/0692c7e3/attachment.html>
More information about the Choqok-devel
mailing list