Review Request 120143: Fix bug 338957 / request more than 20 friends

Ian Schwarz m_105 at gmx.de
Thu Sep 11 14:32:45 UTC 2014



> On Sept. 11, 2014, 2:27 nachm., Andrea Scarpino wrote:
> > I didn't test the patch, anyway I don't get why you can simply add the 2 lines involving the 'count' parameter and keep the rest untouched. Any particular reason?
> 
> Andrea Scarpino wrote:
>     you can't*
> 
> Ian Schwarz wrote:
>     Because some users might have more than 200 friends and you cannot request more than 200 friends at once.

Other changes are because right now, hitting the rate limit results in an empty friends list; and because right now, the dropdown list can be made to contain duplicate entries.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120143/#review66266
-----------------------------------------------------------


On Sept. 11, 2014, 2:22 nachm., Ian Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120143/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 2:22 nachm.)
> 
> 
> Review request for Choqok.
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> see https://bugs.kde.org/show_bug.cgi?id=338957
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapidmessagedialog.cpp 44ddf5b 
>   helperlibs/twitterapihelper/twitterapimicroblog.h b9dd97a 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp 4fc7ee9 
> 
> Diff: https://git.reviewboard.kde.org/r/120143/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Schwarz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20140911/00bec410/attachment.html>


More information about the Choqok-devel mailing list