Review Request 120143: Fix bug 338957 / request more than 20 friends

[Ian Schwarz]

> On Sept. 12, 2014, 3:48 nachm., Mehrdad Momeny wrote:
> > Also please use 4 spaces instead of tab for indentation. (KDE and Choqok coding convention)
> > 
> > BTW, Do you have KDE commit access? (Just want to know)
> > If not, I can fix this and commit it myself.

I don't have any sort of access. I'll try to remember to use 4 space indents.


> On Sept. 12, 2014, 3:48 nachm., Mehrdad Momeny wrote:
> > helperlibs/twitterapihelper/twitterapidmessagedialog.cpp, line 152
> > <https://git.reviewboard.kde.org/r/120143/diff/1/?file=311554#file311554line152>
> >
> >     No! need, the duplicates were removed previously!

As I said, the dropdown list right now can be made to contain duplicate entries without my patch; however it's probably not the line you (rightfully) pointed out, but the one following it (d->comboFriendsList->clear();) that prevents it.


> On Sept. 12, 2014, 3:48 nachm., Mehrdad Momeny wrote:
> > helperlibs/twitterapihelper/twitterapimicroblog.h, line 247
> > <https://git.reviewboard.kde.org/r/120143/diff/1/?file=311555#file311555line247>
> >
> >     I don't see the need for this additional list, we can manage it without this.

If the server returns an empty friends list because we hit the rate limit (not because the friends list is actually empty), Choqok throws away the previously saved friends list. The separate list is there to prevent it (but there may be some other way to do it).


> On Sept. 12, 2014, 3:48 nachm., Mehrdad Momeny wrote:
> > helperlibs/twitterapihelper/twitterapimicroblog.cpp, line 746
> > <https://git.reviewboard.kde.org/r/120143/diff/1/?file=311556#file311556line746>
> >
> >     Here! the duplicates (if any) are removed.

I stand corrected.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120143/#review66353
-----------------------------------------------------------


On Sept. 11, 2014, 2:22 nachm., Ian Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120143/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 2:22 nachm.)
> 
> 
> Review request for Choqok.
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> see https://bugs.kde.org/show_bug.cgi?id=338957
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapidmessagedialog.cpp 44ddf5b 
>   helperlibs/twitterapihelper/twitterapimicroblog.h b9dd97a 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp 4fc7ee9 
> 
> Diff: https://git.reviewboard.kde.org/r/120143/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Schwarz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20140912/9d4e46f7/attachment.html>