Review Request 124036: a bit more porting to writeodf

Jos van den Oever jos at vandenoever.info
Mon Jun 8 07:30:36 BST 2015



> On June 8, 2015, 5:49 a.m., Camilla Boemann wrote:
> > I'd prefer that we don't do any kind of porting like this before 3.2
> > 
> > besides i would prefer no use of namespace and also that we dn't end up with a mix of two different writing frameworks in our code
> > 
> > That said the framework in itself looks like a good idea

Ok, we can do it later. When will 3.2 happen approximately?
Since the porting over to the safer way of writing is a lot of work, the interface to the old method is also still available. Also, adding the safer code in small bits avoid making one huge patch that would need to be rebased often.


- Jos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124036/#review81303
-----------------------------------------------------------


On June 7, 2015, 6:12 p.m., Jos van den Oever wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124036/
> -----------------------------------------------------------
> 
> (Updated June 7, 2015, 6:12 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> a bit more porting to writeodf
> 
> 
> Diffs
> -----
> 
>   filters/libodf2/KoColumn.cpp aab928a 
>   libs/odf/Ko3dScene.cpp 81d7c28 
> 
> Diff: https://git.reviewboard.kde.org/r/124036/diff/
> 
> 
> Testing
> -------
> 
> no
> 
> 
> Thanks,
> 
> Jos van den Oever
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150608/4c9fa073/attachment.htm>


More information about the calligra-devel mailing list