Review Request 124036: a bit more porting to writeodf

[Camilla Boemann]

> On June 8, 2015, 5:49 a.m., Camilla Boemann wrote:
> > I'd prefer that we don't do any kind of porting like this before 3.2
> > 
> > besides i would prefer no use of namespace and also that we dn't end up with a mix of two different writing frameworks in our code
> > 
> > That said the framework in itself looks like a good idea
> 
> Jos van den Oever wrote:
>     Ok, we can do it later. When will 3.2 happen approximately?
>     Since the porting over to the safer way of writing is a lot of work, the interface to the old method is also still available. Also, adding the safer code in small bits avoid making one huge patch that would need to be rebased often.

don't know when, but I hope it will only be about 6 months until we open up for 3.2 development

And yes I understand why you want to take it in bits - but I don't want to end up in a situation where half is ported and half is not. Besides it carries it's own set of risk of typos and errors to switch to a new framework. And we have special logic in some places that needs to be preserved. All in all it's a big undertaking and I'm not sure the benefits are worth the hazzle and risk tbh.


- Camilla


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124036/#review81303
-----------------------------------------------------------


On June 7, 2015, 6:12 p.m., Jos van den Oever wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124036/
> -----------------------------------------------------------
> 
> (Updated June 7, 2015, 6:12 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> a bit more porting to writeodf
> 
> 
> Diffs
> -----
> 
>   filters/libodf2/KoColumn.cpp aab928a 
>   libs/odf/Ko3dScene.cpp 81d7c28 
> 
> Diff: https://git.reviewboard.kde.org/r/124036/diff/
> 
> 
> Testing
> -------
> 
> no
> 
> 
> Thanks,
> 
> Jos van den Oever
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150608/2aaed081/attachment.htm>