Review Request 124036: a bit more porting to writeodf

Camilla Boemann cbr at boemann.dk
Mon Jun 8 06:49:09 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124036/#review81303
-----------------------------------------------------------


I'd prefer that we don't do any kind of porting like this before 3.2

besides i would prefer no use of namespace and also that we dn't end up with a mix of two different writing frameworks in our code

That said the framework in itself looks like a good idea

- Camilla Boemann


On June 7, 2015, 6:12 p.m., Jos van den Oever wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124036/
> -----------------------------------------------------------
> 
> (Updated June 7, 2015, 6:12 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> a bit more porting to writeodf
> 
> 
> Diffs
> -----
> 
>   filters/libodf2/KoColumn.cpp aab928a 
>   libs/odf/Ko3dScene.cpp 81d7c28 
> 
> Diff: https://git.reviewboard.kde.org/r/124036/diff/
> 
> 
> Testing
> -------
> 
> no
> 
> 
> Thanks,
> 
> Jos van den Oever
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150608/c2c17917/attachment.htm>


More information about the calligra-devel mailing list