Review Request 120756: Fix for bug 306097 - find does not work on the full document (Stage)

[Fredy Yanardi]

> On Oct. 23, 2014, 4:55 p.m., Camilla Boemann wrote:
> > libs/kotext/KoFind_p.cpp, line 288
> > <https://git.reviewboard.kde.org/r/120756/diff/1/?file=321848#file321848line288>
> >
> >     so if there is no docment and the application doesn't do as kopa doeswe get into an edless loop ?

I didn't realize this, in fact endless loop will also happen if there is no matched text in any of the shape. Proposed solution is to call emitFindDocumentSignal() only the first time find/replace is invoked.


- Fredy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120756/#review69032
-----------------------------------------------------------


On Oct. 24, 2014, 2:11 a.m., Fredy Yanardi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120756/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 2:11 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 306097
>     http://bugs.kde.org/show_bug.cgi?id=306097
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix for bug 306097 - Find does not work on the full document (Stage). Find does not work because when no text shape is active, KoPAView is not triggered to select the next text shape.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoFind_p.cpp c4143b9 
>   libs/kopageapp/KoPAView.cpp 6e0b519 
>   libs/kotext/FindDirection_p.cpp 7a0052a 
>   libs/kotext/KoFind.h d53baf8 
>   libs/kotext/KoFind_p.h d757099 
> 
> Diff: https://git.reviewboard.kde.org/r/120756/diff/
> 
> 
> Testing
> -------
> 
> Tested on various combinations of find, replace, forward and backward.
> 
> 
> Thanks,
> 
> Fredy Yanardi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141024/252ee51e/attachment.htm>