Review Request 120756: Fix for bug 306097 - find does not work on the full document (Stage)

[Camilla Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120756/#review69032
-----------------------------------------------------------



libs/kopageapp/KoPAView.cpp
<https://git.reviewboard.kde.org/r/120756/#comment48283>

    chane -> change



libs/kotext/KoFind_p.cpp
<https://git.reviewboard.kde.org/r/120756/#comment48284>

    so if there is no docment and the application doesn't do as kopa doeswe get into an edless loop ?


- Camilla Boemann


On Oct. 23, 2014, 4:16 p.m., Fredy Yanardi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120756/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 4:16 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 306097
>     http://bugs.kde.org/show_bug.cgi?id=306097
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix for bug 306097 - Find does not work on the full document (Stage). Find does not work because when no text shape is active, KoPAView is not triggered to select the next text shape.
> 
> 
> Diffs
> -----
> 
>   libs/kopageapp/KoPAView.cpp 6e0b519 
>   libs/kotext/FindDirection_p.cpp 7a0052a 
>   libs/kotext/KoFind.h d53baf8 
>   libs/kotext/KoFind_p.h d757099 
>   libs/kotext/KoFind_p.cpp c4143b9 
> 
> Diff: https://git.reviewboard.kde.org/r/120756/diff/
> 
> 
> Testing
> -------
> 
> Tested on various combinations of find, replace, forward and backward.
> 
> 
> Thanks,
> 
> Fredy Yanardi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141023/2a4bca31/attachment.htm>