Review Request 120756: Fix for bug 306097 - find does not work on the full document (Stage)

[Fredy Yanardi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120756/
-----------------------------------------------------------

(Updated Oct. 24, 2014, 2:11 a.m.)


Review request for Calligra.


Changes
-------

Call emitFindDocumentSignal() only the first time find/replace is invoked to avoid endless loop if no matching text found anywere or caller doesn't supply next shape.


Bugs: 306097
    http://bugs.kde.org/show_bug.cgi?id=306097


Repository: calligra


Description
-------

Fix for bug 306097 - Find does not work on the full document (Stage). Find does not work because when no text shape is active, KoPAView is not triggered to select the next text shape.


Diffs (updated)
-----

  libs/kotext/KoFind_p.cpp c4143b9 
  libs/kopageapp/KoPAView.cpp 6e0b519 
  libs/kotext/FindDirection_p.cpp 7a0052a 
  libs/kotext/KoFind.h d53baf8 
  libs/kotext/KoFind_p.h d757099 

Diff: https://git.reviewboard.kde.org/r/120756/diff/


Testing
-------

Tested on various combinations of find, replace, forward and backward.


Thanks,

Fredy Yanardi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141024/fc3416a6/attachment.htm>