Review Request 118736: cmake files for odb reader and add odb in a drop down

[harshita mistry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118736/
-----------------------------------------------------------

(Updated June 17, 2014, 6:31 a.m.)


Review request for Calligra and Jarosław Staniek.


Changes
-------

1. fixed "kexi/migration/odb/CMakeLists.txt: Minor: this condition not needed since kexi/migration/CMakeLists.txt has it laready" 
2. fixed "kexi/migration/odb/odbmigrate.h: 1. Coding style: better class name: OdbMigrate 2. Missing ": public KexiMigrate"
3. fixed "kexi/migration/odb/odbmigrate.h: constructor not matching the one in odbmigrate.cpp, in fact the header looks like incomplete"
4. fixed "kexi/migration/odb/odbmigrate.cpp: please printf() -> kDebug() everywhere"


Repository: calligra


Description
-------

cmake files that compiles odb reader c++ program and desktop file that adds odb as an import option in the import table drop down menu.


Diffs (updated)
-----

  kexi/migration/odb/CMakeLists.txt PRE-CREATION 
  kexi/migration/odb/odbmigrate.h PRE-CREATION 
  kexi/migration/odb/odbmigrate.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118736/diff/


Testing
-------


Thanks,

harshita mistry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140617/f77a94d9/attachment.htm>