Review Request 118736: cmake files for odb reader and add odb in a drop down

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118736/#review60059
-----------------------------------------------------------


Very good. Simple fixes proposed below.


kexi/migration/odb/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118736/#comment41809>

    Minor: this condition not needed since kexi/migration/CMakeLists.txt has it laready



kexi/migration/odb/odbmigrate.h
<https://git.reviewboard.kde.org/r/118736/#comment41810>

    1. Coding style: better class name: OdbMigrate
    2. Missing ": public KexiMigrate"



kexi/migration/odb/odbmigrate.h
<https://git.reviewboard.kde.org/r/118736/#comment41811>

    constructor not matching the one in odbmigrate.cpp, in fact the header looks like incomplete



kexi/migration/odb/odbmigrate.cpp
<https://git.reviewboard.kde.org/r/118736/#comment41813>

    I'll look at how to de-hardode this and give you advice...



kexi/migration/odb/odbmigrate.cpp
<https://git.reviewboard.kde.org/r/118736/#comment41812>

    please printf() -> kDebug() everywhere


- Jarosław Staniek


On June 14, 2014, 7:06 a.m., harshita mistry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118736/
> -----------------------------------------------------------
> 
> (Updated June 14, 2014, 7:06 a.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> cmake files that compiles odb reader c++ program and desktop file that adds odb as an import option in the import table drop down menu.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 256d810 
>   kexi/migration/CMakeLists.txt 2478b10 
>   kexi/migration/odb/CMakeLists.txt PRE-CREATION 
>   kexi/migration/odb/keximigrate_odb.desktop PRE-CREATION 
>   kexi/migration/odb/odbmigrate.h PRE-CREATION 
>   kexi/migration/odb/odbmigrate.cpp PRE-CREATION 
>   kexi/migration/odb/reader/OdbReader.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118736/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> harshita mistry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140614/a703b541/attachment.htm>