Review Request 118736: cmake files for odb reader and add odb in a drop down

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118736/#review60226
-----------------------------------------------------------


Good job! 
Note: It's enough to click "Fixed" button for each issue you've fixed. It will be noted.


CMakeLists.txt
<https://git.reviewboard.kde.org/r/118736/#comment41969>

    why we drop these checks?



kexi/migration/odb/odbmigrate.h
<https://git.reviewboard.kde.org/r/118736/#comment41961>

    we're indenting public: to column #0
    for example see kexi/migration/mysql/mysqlmigrate.h



kexi/migration/odb/odbmigrate.h
<https://git.reviewboard.kde.org/r/118736/#comment41960>

    extra public: not needed



kexi/migration/odb/odbmigrate.cpp
<https://git.reviewboard.kde.org/r/118736/#comment41962>

    We need to uncomment this so the plugin gets exported.



kexi/migration/odb/odbmigrate.cpp
<https://git.reviewboard.kde.org/r/118736/#comment41966>

    Better to check ret != JNI_OK
    
    (http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html)



kexi/migration/odb/odbmigrate.cpp
<https://git.reviewboard.kde.org/r/118736/#comment41963>

    Convention: \n's not needed



kexi/migration/odb/odbmigrate.cpp
<https://git.reviewboard.kde.org/r/118736/#comment41967>

    JNIEnv *env needs to be used in other methods so let's put it somewhere else.



kexi/migration/odb/odbmigrate.cpp
<https://git.reviewboard.kde.org/r/118736/#comment41964>

    lines 55-57: coding style



kexi/migration/odb/odbmigrate.cpp
<https://git.reviewboard.kde.org/r/118736/#comment41965>

    \n not needed



kexi/migration/odb/odbmigrate.cpp
<https://git.reviewboard.kde.org/r/118736/#comment41968>

    We'll want DestroyJavaVM() 



kexi/migration/odb/odbmigrate.cpp
<https://git.reviewboard.kde.org/r/118736/#comment41970>

    do we need to drop these functions?


- Jarosław Staniek


On June 17, 2014, 6:31 a.m., harshita mistry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118736/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 6:31 a.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> cmake files that compiles odb reader c++ program and desktop file that adds odb as an import option in the import table drop down menu.
> 
> 
> Diffs
> -----
> 
>   kexi/migration/odb/CMakeLists.txt PRE-CREATION 
>   kexi/migration/odb/odbmigrate.h PRE-CREATION 
>   kexi/migration/odb/odbmigrate.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118736/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> harshita mistry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140617/19c5b309/attachment.htm>