Review Request 118571: Added back commented out test

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118571/#review59736
-----------------------------------------------------------



libs/db/tests/TestConnection.cpp
<https://git.reviewboard.kde.org/r/118571/#comment41639>

    please remove this commented line



libs/db/tests/TestConnection.cpp
<https://git.reviewboard.kde.org/r/118571/#comment41640>

    QVERIFY2(conn->disconnect(), "Failed to disconnect database") is needed here too so individual test can be executed (and  one or even more times)
    
    



libs/db/tests/TestConnection.cpp
<https://git.reviewboard.kde.org/r/118571/#comment41638>

    Use 'delete conn' instead; it will  remove from the driver's connections. I advised to call disconnect() in individual tests.



libs/db/tests/tables_test.h
<https://git.reviewboard.kde.org/r/118571/#comment41641>

    please remove changes to this file completely from the patch


- Jarosław Staniek


On June 6, 2014, 7:58 a.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118571/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 7:58 a.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Added back commented out test
> 
> 
> Addressed issues from the review
> 
> 
> Added query parse tests
> 
> Initial tests identify the issue in review 118519
> 
> 
> Diffs
> -----
> 
>   libs/db/tests/TestConnection.h 8f6147356c8885d7e41b7004f07b1d8b19cd7d66 
>   libs/db/tests/TestConnection.cpp fa38d64832f75d896288e1a7da6cf85f853ae261 
>   libs/db/tests/tables_test.h a748c6588a8d2a558c69f9ae57abe301bd701319 
> 
> Diff: https://git.reviewboard.kde.org/r/118571/diff/
> 
> 
> Testing
> -------
> 
> Ran new tests with patch from 118519 and tests pass.
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140610/f07970a5/attachment.htm>