Review Request 118571: Added back commented out test

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118571/#review59737
-----------------------------------------------------------


Adam,
After updating patch, we do not want to change summary and description, just describe changes that the update means. Now the summary looks misleading "Added back commented out test"... could you please revert the summary and the description to the original?

- Jarosław Staniek


On June 6, 2014, 7:58 a.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118571/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 7:58 a.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Added back commented out test
> 
> 
> Addressed issues from the review
> 
> 
> Added query parse tests
> 
> Initial tests identify the issue in review 118519
> 
> 
> Diffs
> -----
> 
>   libs/db/tests/TestConnection.h 8f6147356c8885d7e41b7004f07b1d8b19cd7d66 
>   libs/db/tests/TestConnection.cpp fa38d64832f75d896288e1a7da6cf85f853ae261 
>   libs/db/tests/tables_test.h a748c6588a8d2a558c69f9ae57abe301bd701319 
> 
> Diff: https://git.reviewboard.kde.org/r/118571/diff/
> 
> 
> Testing
> -------
> 
> Ran new tests with patch from 118519 and tests pass.
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140610/63a348ac/attachment.htm>