Review Request 118571: Added back commented out test
Adam Pigg
adam at piggz.co.uk
Fri Jun 6 08:58:24 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118571/
-----------------------------------------------------------
(Updated June 6, 2014, 7:58 a.m.)
Review request for Calligra and Jarosław Staniek.
Changes
-------
Fixed issues identified by staniek
Summary (updated)
-----------------
Added back commented out test
Repository: calligra
Description (updated)
-------
Added back commented out test
Addressed issues from the review
Added query parse tests
Initial tests identify the issue in review 118519
Diffs (updated)
-----
libs/db/tests/TestConnection.h 8f6147356c8885d7e41b7004f07b1d8b19cd7d66
libs/db/tests/TestConnection.cpp fa38d64832f75d896288e1a7da6cf85f853ae261
libs/db/tests/tables_test.h a748c6588a8d2a558c69f9ae57abe301bd701319
Diff: https://git.reviewboard.kde.org/r/118571/diff/
Testing
-------
Ran new tests with patch from 118519 and tests pass.
Thanks,
Adam Pigg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140606/6b699c5a/attachment.htm>
More information about the calligra-devel
mailing list