Review Request 118571: Added query parse tests

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118571/#review59354
-----------------------------------------------------------



libs/db/tests/TestConnection.cpp
<https://git.reviewboard.kde.org/r/118571/#comment41306>

    Very good, just this would be better separate method, testQueries(). Prepend conn->connect(), conn->useDatabase(), and will work. 
    Keep conn->closeDatabase() and conn->disconnect() in the new method.
    
    In Predicate we'll even validate error massages, returned records, etc. :)



libs/db/tests/tables_test.h
<https://git.reviewboard.kde.org/r/118571/#comment41307>

    After the change requested above, this removal is not needed. tablesTest() is used elsewhere so this removal probably breaks other things.


- Jarosław Staniek


On June 5, 2014, 5:59 p.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118571/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 5:59 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Added query parse tests
> 
> Initial tests identify the issue in review 118519
> 
> 
> Diffs
> -----
> 
>   libs/db/tests/TestConnection.cpp fa38d64832f75d896288e1a7da6cf85f853ae261 
>   libs/db/tests/tables_test.h a748c6588a8d2a558c69f9ae57abe301bd701319 
> 
> Diff: https://git.reviewboard.kde.org/r/118571/diff/
> 
> 
> Testing
> -------
> 
> Ran new tests with patch from 118519 and tests pass.
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140605/12bbfddb/attachment.htm>