Review Request 119222: Make labels inline-editable

[Friedrich W. H. Kossebau]

> On Juli 13, 2014, 6:45 nachm., Kamil Łysik wrote:
> > libs/koreport/items/label/KoReportDesignerItemLabel.cpp, line 193
> > <https://git.reviewboard.kde.org/r/119222/diff/1/?file=289614#file289614line193>
> >
> >     I got build error: adding 
> >     #include <QTextCursor>
> >     fixed this. Is this include not required?

I have done some cleanup of unneeded includes in the base libraries the last two days (to reduce number of recompiles on changes etc), so it can be now needed to include that one explicitely


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119222/#review62258
-----------------------------------------------------------


On Juli 10, 2014, 9:22 nachm., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119222/
> -----------------------------------------------------------
> 
> (Updated Juli 10, 2014, 9:22 nachm.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Bugs: 336825
>     http://bugs.kde.org/show_bug.cgi?id=336825
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Usage:
> Insert label
> Double click to enter inline-edit mode
> -Label text is selected and can be overwritten
> Click away from item to exit edit mode
> -Item text is updated with editor text
> 
> 
> Diffs
> -----
> 
>   libs/koreport/items/label/KoReportDesignerItemLabel.h b2aa78f4bb444fecffc4d01b09901e97204350ee 
>   libs/koreport/items/label/KoReportDesignerItemLabel.cpp 8974a807b122649a6c6daf61f34c678cb5ec9961 
> 
> Diff: https://git.reviewboard.kde.org/r/119222/diff/
> 
> 
> Testing
> -------
> 
> Inserted label on new report and checked usage
> 
> Loaded existing report and ensured labels are editiable
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140713/6fa69b69/attachment.htm>