Review Request 119222: Make labels inline-editable

[Adam Pigg]

> On July 13, 2014, 6:45 p.m., Kamil Łysik wrote:
> > libs/koreport/items/label/KoReportDesignerItemLabel.cpp, line 193
> > <https://git.reviewboard.kde.org/r/119222/diff/1/?file=289614#file289614line193>
> >
> >     I got build error: adding 
> >     #include <QTextCursor>
> >     fixed this. Is this include not required?
> 
> Friedrich W. H. Kossebau wrote:
>     I have done some cleanup of unneeded includes in the base libraries the last two days (to reduce number of recompiles on changes etc), so it can be now needed to include that one explicitely

Yeah, ive just had to add it locally


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119222/#review62258
-----------------------------------------------------------


On July 14, 2014, 5:05 p.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119222/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 5:05 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Bugs: 336825
>     http://bugs.kde.org/show_bug.cgi?id=336825
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Usage:
> Insert label
> Double click to enter inline-edit mode
> -Label text is selected and can be overwritten
> Click away from item to exit edit mode
> -Item text is updated with editor text
> 
> 
> Diffs
> -----
> 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 63152a7d7efb0917534a869df436292616ef0284 
>   libs/koreport/wrtembed/reportscene.cpp 2e9c54d29c135c041db75d2a843ea5bd8318e1c1 
>   libs/koreport/renderer/odtframe/KoOdtFrameReportCheckBox.cpp 719e890c53896c9d4a12ad0793f5d9e84e45943f 
>   libs/koreport/items/label/BoundedTextItem.cpp PRE-CREATION 
>   libs/koreport/items/label/KoReportDesignerItemLabel.h b2aa78f4bb444fecffc4d01b09901e97204350ee 
>   libs/koreport/items/label/KoReportDesignerItemLabel.cpp 8974a807b122649a6c6daf61f34c678cb5ec9961 
>   libs/koreport/items/text/KoReportDesignerItemText.cpp 51e12d3020104fec4cb8cc473d5499e085dfbf2c 
>   libs/koreport/renderer/KoReportPrintRenderer.cpp 4018c3b2febbc0dfce9fc528f3f168fa0bc62cbb 
>   libs/koreport/renderer/KoReportScreenRenderer.cpp d47ce494b957c225ffaf264fe85ea9208165affb 
>   libs/koreport/CMakeLists.txt 26d299c54189f5b402348baa1821f7641a1afd74 
>   libs/koreport/items/check/KoReportDesignerItemCheck.cpp 5bebc6c4e10f2243919a0b2668ea3a8ff02ce954 
>   libs/koreport/items/field/KoReportDesignerItemField.cpp 0dc9325a1c04dda83bdc7c2a3e4eae5eb500c52f 
>   libs/koreport/items/image/KoReportDesignerItemImage.cpp 87e46a1ca3ad6dc0a025eeac90dac12e12029691 
>   libs/koreport/items/label/BoundedTextItem.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119222/diff/
> 
> 
> Testing
> -------
> 
> Inserted label on new report and checked usage
> 
> Loaded existing report and ensured labels are editiable
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140714/050e1a0d/attachment.htm>