Review Request 119222: Make labels inline-editable
Kamil Łysik
kamillys at gmail.com
Sun Jul 13 19:45:47 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119222/#review62258
-----------------------------------------------------------
libs/koreport/items/label/KoReportDesignerItemLabel.cpp
<https://git.reviewboard.kde.org/r/119222/#comment43259>
I got build error: adding
#include <QTextCursor>
fixed this. Is this include not required?
- Kamil Łysik
On July 10, 2014, 9:22 p.m., Adam Pigg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119222/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 9:22 p.m.)
>
>
> Review request for Calligra and Jarosław Staniek.
>
>
> Bugs: 336825
> http://bugs.kde.org/show_bug.cgi?id=336825
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Usage:
> Insert label
> Double click to enter inline-edit mode
> -Label text is selected and can be overwritten
> Click away from item to exit edit mode
> -Item text is updated with editor text
>
>
> Diffs
> -----
>
> libs/koreport/items/label/KoReportDesignerItemLabel.h b2aa78f4bb444fecffc4d01b09901e97204350ee
> libs/koreport/items/label/KoReportDesignerItemLabel.cpp 8974a807b122649a6c6daf61f34c678cb5ec9961
>
> Diff: https://git.reviewboard.kde.org/r/119222/diff/
>
>
> Testing
> -------
>
> Inserted label on new report and checked usage
>
> Loaded existing report and ensured labels are editiable
>
>
> Thanks,
>
> Adam Pigg
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140713/de5ff7f4/attachment.htm>
More information about the calligra-devel
mailing list