Review Request 115352: Fix the Stroke and Shape Id of the Pencil Tool

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115352/#review48887
-----------------------------------------------------------


This review has been submitted with commit 3da1a3530b761c1f1990cfe32f35dae232855888 by Dmitry Kazakov to branch calligra/2.8.

- Commit Hook


On Jan. 28, 2014, 1:37 p.m., Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115352/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 1:37 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch fixes two issues:
>   
> 1) Crash in Krita caused by non-initialized id of the shape
> BUG:329967 (https://bugs.kde.org/show_bug.cgi?id=329967)
>     
> 2) Wrong stroke parameters of KoPencilTool calligra-wise. The stroke was not initilized properly.
> 
> 
> Diffs
> -----
> 
>   libs/basicflakes/tools/KoCreatePathTool.cpp a4f16e3 
>   libs/basicflakes/tools/KoPencilTool.h 53add32 
>   libs/basicflakes/tools/KoPencilTool.cpp ed13e45 
>   libs/widgets/KoStrokeConfigWidget.h 7182098 
>   libs/widgets/KoStrokeConfigWidget.cpp 3a0dc84 
> 
> Diff: https://git.reviewboard.kde.org/r/115352/diff/
> 
> 
> Testing
> -------
> 
> Tested in Krita and Karbon
> 
> 
> Thanks,
> 
> Dmitry Kazakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140204/aed373fd/attachment.htm>