<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115352/">https://git.reviewboard.kde.org/r/115352/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3da1a3530b761c1f1990cfe32f35dae232855888 by Dmitry Kazakov to branch calligra/2.8.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On January 28th, 2014, 1:37 p.m. UTC, Dmitry Kazakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Dmitry Kazakov.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2014, 1:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes two issues:
1) Crash in Krita caused by non-initialized id of the shape
BUG:329967 (https://bugs.kde.org/show_bug.cgi?id=329967)
2) Wrong stroke parameters of KoPencilTool calligra-wise. The stroke was not initilized properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested in Krita and Karbon</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/basicflakes/tools/KoCreatePathTool.cpp <span style="color: grey">(a4f16e3)</span></li>
<li>libs/basicflakes/tools/KoPencilTool.h <span style="color: grey">(53add32)</span></li>
<li>libs/basicflakes/tools/KoPencilTool.cpp <span style="color: grey">(ed13e45)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.h <span style="color: grey">(7182098)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.cpp <span style="color: grey">(3a0dc84)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115352/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>