Review Request 119579: In docx import filter handle outline level of paragraphs
Inge Wallin
inge at lysator.liu.se
Sun Aug 10 11:18:18 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119579/#review64146
-----------------------------------------------------------
Ship it!
Looks good. I commented on a trivial readability issue but that's really minor.
If this works for your test documents, then feel free to merge. And now also implement the same in the export filter. :)
filters/words/docx/import/DocxXmlDocumentReader.cpp
<https://git.reviewboard.kde.org/r/119579/#comment44796>
While this is correct (according to the comment, didn't read the spec), wouldn't it be clearer to use == instead of != ?
- Inge Wallin
On Aug. 3, 2014, 10:34 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119579/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2014, 10:34 p.m.)
>
>
> Review request for Calligra, Inge Wallin and Lassi Nieminen.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Works for my testing docs, and now also done with the spec read.
>
>
> Diffs
> -----
>
> filters/words/docx/import/DocxXmlDocumentReader.h a61fe56
> filters/words/docx/import/DocxXmlDocumentReader.cpp dccda61
>
> Diff: https://git.reviewboard.kde.org/r/119579/diff/
>
>
> Testing
> -------
>
> Compared ToC structure for my testing docx samples as seen by LO and Calligra
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140810/50ef307b/attachment.htm>
More information about the calligra-devel
mailing list