Review Request 119579: In docx import filter handle outline level of paragraphs

[Friedrich W. H. Kossebau]

> On Aug. 3, 2014, 6:50 vorm., Lassi Nieminen wrote:
> > Looks good to me.
> > 
> > Not sure what spec says but if spec allows paragraph style in the document file to define outlineLvl
> > then potentially isHeading should check also the existence of the property from current m_currentParagraphStyle.

Yes, good hint, at least from what I saw in the schema and the spec from ECMA the direct style data can also define the outline level (just nothing like that in my few test sample docs). Changed the code some more, also to take full inheritance into account.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119579/#review63694
-----------------------------------------------------------


On Aug. 3, 2014, 10:34 nachm., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119579/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2014, 10:34 nachm.)
> 
> 
> Review request for Calligra, Inge Wallin and Lassi Nieminen.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Works for my testing docs, and now also done with the spec read.
> 
> 
> Diffs
> -----
> 
>   filters/words/docx/import/DocxXmlDocumentReader.h a61fe56 
>   filters/words/docx/import/DocxXmlDocumentReader.cpp dccda61 
> 
> Diff: https://git.reviewboard.kde.org/r/119579/diff/
> 
> 
> Testing
> -------
> 
> Compared ToC structure for my testing docx samples as seen by LO and Calligra
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140803/a0ea2061/attachment.htm>