Review Request 119579: In docx import filter handle outline level of paragraphs

[Friedrich W. H. Kossebau]

> On Aug. 10, 2014, 10:18 vorm., Inge Wallin wrote:
> > filters/words/docx/import/DocxXmlDocumentReader.cpp, line 3792
> > <https://git.reviewboard.kde.org/r/119579/diff/2/?file=295244#file295244line3792>
> >
> >     While this is correct (according to the comment, didn't read the spec), wouldn't it be clearer to use == instead of != ?

If you prefer that more, I do not have a strong opinion on this (just usually check for usual cases first) and thus changed it to what you proposed.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119579/#review64146
-----------------------------------------------------------


On Aug. 10, 2014, 1:54 nachm., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119579/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2014, 1:54 nachm.)
> 
> 
> Review request for Calligra, Inge Wallin and Lassi Nieminen.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Works for my testing docs, and now also done with the spec read.
> 
> 
> Diffs
> -----
> 
>   filters/words/docx/import/DocxXmlDocumentReader.h a61fe56 
>   filters/words/docx/import/DocxXmlDocumentReader.cpp dccda61 
> 
> Diff: https://git.reviewboard.kde.org/r/119579/diff/
> 
> 
> Testing
> -------
> 
> Compared ToC structure for my testing docx samples as seen by LO and Calligra
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140810/e917d3ad/attachment.htm>