Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

[Aman Madaan]

> On March 28, 2013, 9:36 a.m., C. Boemann wrote:
> > All labels leading up to (say) a line edit should end with ":"
> > 
> > 
> > In the "web link" page it should be "Advanced options" not "Additional Options for web links", and it should be a QGroupBox with option Flat set
> > 
> > The fetch button should be a QPushButton "and say "Get title from URL" and should be above the lineedit.
> > 
> > It shouldn't change the link. If you want to keep that functionality add a QPushButton under advanced named "Replace URL with redirected URL"
> > 
> > 
> > In the "link to boomark" page it would be better to also provide a list of bookmarks. The completion feature is very nice still :)
> > 
> > 
> > The manage bookmark dialog should have title of "Manage bookmarks", and should also have a button to insert.
> > Typing a name in the quick insertion that already exists should make some kind of subtle warning and prevent the user from pressing enter. The user should never have to see the error dialog. Forget what I wrote about bringing up the manage dialog, the waning and preventing pressing enter should be enough (the warning should suggest to use "Manage bookmarks" though)

Thanks for the comprehensive review.

>>All labels leading up to (say) a line edit should end with ":"
   Done

>>In the "web link" page it should be "Advanced options" not "Additional Options for web links", and it should be a QGroupBox with option Flat set
   Done

>>The fetch button should be a QPushButton "and say "Get title from URL" and should be above the lineedit.
  Done. Although I am not sure about the size of the QPushButton.
 
>>It shouldn't change the link. If you want to keep that functionality add a QPushButton under advanced named "Replace URL with redirected URL"
  The redirections are not an option but compulsory if I need to fetch the title from the given URL. Not providing this functionality explicitly for now.

>>In the "link to boomark" page it would be better to also provide a list of bookmarks. The completion feature is very nice still :)
  Added a list of bookmarks. 

>>The manage bookmark dialog should have title of "Manage bookmarks", and should also have a button to insert.
  Done.

>>Typing a name in the quick insertion that already exists should make some kind of subtle warning and prevent the user from pressing enter. The user should never have to see the error dialog. Forget what I wrote about bringing up the manage dialog, the waning and preventing pressing enter should be enough (the warning should suggest to use "Manage bookmarks" though)

 If a user tries to enter a duplicate bookmark, a warning message is displayed with the information about "Manage Bookmarks". The bookmark is not  inserted. I am not sure about preventing pressing enter part.


- Aman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109746/#review29984
-----------------------------------------------------------


On March 28, 2013, 8:42 p.m., Aman Madaan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109746/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 8:42 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch adds the following features : 
> 
> 1. Inserting hyperlinks
>    -- User has a choice of inserting a link by specifying the target and the link text. Additionally, the 
>       user may supply values for target and rel attributes using a drop down list.  
>    -- The user may fetch the title from the web page itself (contents of the "title" tag ). This feature also
>       handles URL redirects. For example, ieee.com is finally redirected to http://www.ieee.org/index.html.
>       This feature will especially help in cases when a user has a list of links referred to and a list of 
>       references has to be created. Just copy/pasting the URL, clicking fetch and then insert will do the job.
> 
> 2. Linking to bookmarks
>    -- A user can specify a bookmark name and the link text. To help the user with inserting bookmark, 
>       an auto completer is used. This becomes helpful when the bookmarks have been given a name that 
>       are related to the context. (lastpagefirstpara or conclusions).
> 
> 3. Adding Bookmark using a labeled widget ( similar to the way footnote and endnote labels are entered )
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/CMakeLists.txt b2bf9ae 
>   plugins/textshape/ReferencesTool.h 21caea8 
>   plugins/textshape/ReferencesTool.cpp 46bf06f 
>   plugins/textshape/dialogs/BookmarkLinkInsertionWidget.h PRE-CREATION 
>   plugins/textshape/dialogs/BookmarkLinkInsertionWidget.cpp PRE-CREATION 
>   plugins/textshape/dialogs/BookmarkLinkInsertionWidget.ui PRE-CREATION 
>   plugins/textshape/dialogs/LinkInsertionDialog.h PRE-CREATION 
>   plugins/textshape/dialogs/LinkInsertionDialog.cpp PRE-CREATION 
>   plugins/textshape/dialogs/LinkInsertionDialog.ui PRE-CREATION 
>   plugins/textshape/dialogs/SelectBookmark.ui PRE-CREATION 
>   plugins/textshape/dialogs/SelectBookmarkDialog.h PRE-CREATION 
>   plugins/textshape/dialogs/SelectBookmarkDialog.cpp PRE-CREATION 
>   plugins/textshape/dialogs/SimpleBookmarkWidget.h PRE-CREATION 
>   plugins/textshape/dialogs/SimpleBookmarkWidget.cpp PRE-CREATION 
>   plugins/textshape/dialogs/SimpleBookmarkWidget.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp 2d1c1de 
>   plugins/textshape/dialogs/SimpleCitationBibliographyWidget.ui 55699bb 
>   plugins/textshape/dialogs/SimpleLinksWidget.h PRE-CREATION 
>   plugins/textshape/dialogs/SimpleLinksWidget.cpp PRE-CREATION 
>   plugins/textshape/dialogs/SimpleLinksWidget.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleTableOfContentsWidget.h adfd010 
>   plugins/textshape/dialogs/WeblinkInsertionWidget.h PRE-CREATION 
>   plugins/textshape/dialogs/WeblinkInsertionWidget.cpp PRE-CREATION 
>   plugins/textshape/dialogs/WeblinkInsertionWidget.ui PRE-CREATION 
>   words/part/KWView.cpp 8639acd 
> 
> Diff: http://git.reviewboard.kde.org/r/109746/diff/
> 
> 
> Testing
> -------
> 
> I have tested the following components : 
> 	
> 1	  Inserting Hyperlinks			
> 1.1	Simplest case  (works)		
> 1.2	Fetch title from URL (works)		
> 1.3	Fetch title from URL which has re directions (works)		
> 1.4	specify a URL without a scheme (works, appending an http:// to all the schemeless urls)
> 1.5	fetching from an non existing URL (Time out occurs and notifies user about the same)
> 				
> 2	Adding Bookmarks			
> 2.1	Simplest case (works)		
> 2.2	Adding a duplicate bookmark i.e. using a name that has been used before(User is notified and bookmark addition is aborted)	
> 				
> 3	Adding link to a bookmark			
> 3.1	Simplest case (works)		
> 3.2	Adding a link to a non existing bookmark (works,User is notified about non existence of the bookmark)
> 				
> 4	Manage bookmarks
> 4.1	user clicks on manage bookmarks	(works, Copy pasted the existing implementation. Looks like delete bookmark is broken.)	
> 
> 
> Thanks,
> 
> Aman Madaan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130328/b481340f/attachment.htm>