<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109746/">http://git.reviewboard.kde.org/r/109746/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 28th, 2013, 9:36 a.m. UTC, <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All labels leading up to (say) a line edit should end with ":"
In the "web link" page it should be "Advanced options" not "Additional Options for web links", and it should be a QGroupBox with option Flat set
The fetch button should be a QPushButton "and say "Get title from URL" and should be above the lineedit.
It shouldn't change the link. If you want to keep that functionality add a QPushButton under advanced named "Replace URL with redirected URL"
In the "link to boomark" page it would be better to also provide a list of bookmarks. The completion feature is very nice still :)
The manage bookmark dialog should have title of "Manage bookmarks", and should also have a button to insert.
Typing a name in the quick insertion that already exists should make some kind of subtle warning and prevent the user from pressing enter. The user should never have to see the error dialog. Forget what I wrote about bringing up the manage dialog, the waning and preventing pressing enter should be enough (the warning should suggest to use "Manage bookmarks" though)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the comprehensive review.
>>All labels leading up to (say) a line edit should end with ":"
Done
>>In the "web link" page it should be "Advanced options" not "Additional Options for web links", and it should be a QGroupBox with option Flat set
Done
>>The fetch button should be a QPushButton "and say "Get title from URL" and should be above the lineedit.
Done. Although I am not sure about the size of the QPushButton.
>>It shouldn't change the link. If you want to keep that functionality add a QPushButton under advanced named "Replace URL with redirected URL"
The redirections are not an option but compulsory if I need to fetch the title from the given URL. Not providing this functionality explicitly for now.
>>In the "link to boomark" page it would be better to also provide a list of bookmarks. The completion feature is very nice still :)
Added a list of bookmarks.
>>The manage bookmark dialog should have title of "Manage bookmarks", and should also have a button to insert.
Done.
>>Typing a name in the quick insertion that already exists should make some kind of subtle warning and prevent the user from pressing enter. The user should never have to see the error dialog. Forget what I wrote about bringing up the manage dialog, the waning and preventing pressing enter should be enough (the warning should suggest to use "Manage bookmarks" though)
If a user tries to enter a duplicate bookmark, a warning message is displayed with the information about "Manage Bookmarks". The bookmark is not inserted. I am not sure about preventing pressing enter part.
</pre>
<br />
<p>- Aman</p>
<br />
<p>On March 28th, 2013, 8:42 p.m. UTC, Aman Madaan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Aman Madaan.</div>
<p style="color: grey;"><i>Updated March 28, 2013, 8:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds the following features :
1. Inserting hyperlinks
-- User has a choice of inserting a link by specifying the target and the link text. Additionally, the
user may supply values for target and rel attributes using a drop down list.
-- The user may fetch the title from the web page itself (contents of the "title" tag ). This feature also
handles URL redirects. For example, ieee.com is finally redirected to http://www.ieee.org/index.html.
This feature will especially help in cases when a user has a list of links referred to and a list of
references has to be created. Just copy/pasting the URL, clicking fetch and then insert will do the job.
2. Linking to bookmarks
-- A user can specify a bookmark name and the link text. To help the user with inserting bookmark,
an auto completer is used. This becomes helpful when the bookmarks have been given a name that
are related to the context. (lastpagefirstpara or conclusions).
3. Adding Bookmark using a labeled widget ( similar to the way footnote and endnote labels are entered )
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested the following components :
1 Inserting Hyperlinks
1.1 Simplest case (works)
1.2 Fetch title from URL (works)
1.3 Fetch title from URL which has re directions (works)
1.4 specify a URL without a scheme (works, appending an http:// to all the schemeless urls)
1.5 fetching from an non existing URL (Time out occurs and notifies user about the same)
2 Adding Bookmarks
2.1 Simplest case (works)
2.2 Adding a duplicate bookmark i.e. using a name that has been used before(User is notified and bookmark addition is aborted)
3 Adding link to a bookmark
3.1 Simplest case (works)
3.2 Adding a link to a non existing bookmark (works,User is notified about non existence of the bookmark)
4 Manage bookmarks
4.1 user clicks on manage bookmarks (works, Copy pasted the existing implementation. Looks like delete bookmark is broken.)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(b2bf9ae)</span></li>
<li>plugins/textshape/ReferencesTool.h <span style="color: grey">(21caea8)</span></li>
<li>plugins/textshape/ReferencesTool.cpp <span style="color: grey">(46bf06f)</span></li>
<li>plugins/textshape/dialogs/BookmarkLinkInsertionWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/BookmarkLinkInsertionWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/BookmarkLinkInsertionWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/LinkInsertionDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/LinkInsertionDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/LinkInsertionDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SelectBookmark.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SelectBookmarkDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SelectBookmarkDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleBookmarkWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleBookmarkWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleBookmarkWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp <span style="color: grey">(2d1c1de)</span></li>
<li>plugins/textshape/dialogs/SimpleCitationBibliographyWidget.ui <span style="color: grey">(55699bb)</span></li>
<li>plugins/textshape/dialogs/SimpleLinksWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleLinksWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleLinksWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleTableOfContentsWidget.h <span style="color: grey">(adfd010)</span></li>
<li>plugins/textshape/dialogs/WeblinkInsertionWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/WeblinkInsertionWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/WeblinkInsertionWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(8639acd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109746/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>