Review Request 111044: Implement borders for shapes

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111044/
-----------------------------------------------------------

(Updated June 22, 2013, 6:28 a.m.)


Review request for Calligra, C. Boemann, Boudewijn Rempt, and Thorsten Zachmann.


Changes
-------

Here is the next version.  All the issues pointed out in the code are fixed.  The crashes that Thorsten saw are commented upon separately.


Description
-------

This patch implements loading, saving and painting of borders for shapes in general. It also implements calls to actually paint borders in particular for the picture shape and text shape.

At the same time I moved border painting from KWCanvasBase to KoBorder, which I announced some weeks ago that I wanted to do.

A patch this deep in the libraries should not go in without a run of cstester. I would be glad for help with this since I only have a semi-weak laptop.


Diffs (updated)
-----

  libs/flake/KoShape.h fe6cc3f 
  libs/flake/KoShape.cpp 6d14a8c 
  libs/flake/KoShape_p.h aa6633c 
  libs/odf/KoBorder.h bdbf86e 
  libs/odf/KoBorder.cpp 58f8e45 
  plugins/pictureshape/PictureShape.cpp 976fadd 
  plugins/textshape/TextShape.cpp b230f0a 
  words/part/KWCanvasBase.cpp 7d12890 

Diff: http://git.reviewboard.kde.org/r/111044/diff/


Testing
-------

Tested with all the files with the string "border" in it in the test suite.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130622/45701dc7/attachment.htm>