Review Request 111044: Implement borders for shapes

[Inge Wallin]

> On June 19, 2013, 3:18 p.m., Thorsten Zachmann wrote:
> > With the following patch the files 
> > 
> > ./marketing.openoffice.org%2Fooocon2%30%307%2Fprogramme%2Fwednesday_186.odp
> > ./www.mwsmediapodcasts.com%2Fmedia%2Fdocuments%2Fdigitalyouth%2Fhangingoutmessingaroundgeekingout.odt
> > 
> > from the test set crash with a segmentation fault.
> > 
> > Will look if there additional regressions when I find some free time.
> > 
> > If you need the files please let me know and I will forward them to you.

I have now fixed the issues that boemann pointed out and also looked at these files.  I cannot get the hangingout....odt file to crash so probably something is fixed there.  The wednesday_186.odp file still crashes but the backtrace is extremely strange. There is a call to KoShapeFactoryBase::createShapeFromOdf and then suddenly it is in saveOdf() in the threedShape.  I can't see any possible way this could happen.  Any hint on how to debug this would be valuable.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111044/#review34682
-----------------------------------------------------------


On June 15, 2013, 6:35 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111044/
> -----------------------------------------------------------
> 
> (Updated June 15, 2013, 6:35 p.m.)
> 
> 
> Review request for Calligra, C. Boemann, Boudewijn Rempt, and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> This patch implements loading, saving and painting of borders for shapes in general. It also implements calls to actually paint borders in particular for the picture shape and text shape.
> 
> At the same time I moved border painting from KWCanvasBase to KoBorder, which I announced some weeks ago that I wanted to do.
> 
> A patch this deep in the libraries should not go in without a run of cstester. I would be glad for help with this since I only have a semi-weak laptop.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShape.h fe6cc3f 
>   libs/flake/KoShape.cpp 6d14a8c 
>   libs/flake/KoShape_p.h aa6633c 
>   libs/odf/KoBorder.h bdbf86e 
>   libs/odf/KoBorder.cpp 58f8e45 
>   plugins/pictureshape/PictureShape.cpp 976fadd 
>   plugins/textshape/TextShape.cpp b230f0a 
>   words/part/KWCanvasBase.cpp 7d12890 
> 
> Diff: http://git.reviewboard.kde.org/r/111044/diff/
> 
> 
> Testing
> -------
> 
> Tested with all the files with the string "border" in it in the test suite.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130622/4f140673/attachment.htm>