Review Request 111044: Implement borders for shapes

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111044/#review35264
-----------------------------------------------------------


I found 2 problems with the patch. I think I already marked the problems in the review request. 

1. When showing a border of a shape in the UI the border rectangle changes with the zoom level.
Files to test:
learn.creativecommons.org%2Fwp-content%2Fuploads%2F2%30%309%2F%304%2Fcclearn-explanations-oer-and-cc-licenses-%305-apr-%309.odt Page 3
miha.ef.uni-lj.si%2F_dokumenti%2Fwp%2Fgovernment-knowledge-wp_final.doc Page 11
mypro-realty.com%2FDOCs%2FGet%20Ready%20for%20a%20Home.docx Page 1

2. Sometimes the boarder is not set correctly
www.buec.udel.edu%2Fservam%2FMISY34%30%2FSyllabus.docx Page 4



libs/flake/KoShape.cpp
<http://git.reviewboard.kde.org/r/111044/#comment25838>

    I think the painter should not be converted here as it is already done in the calling code.



libs/odf/KoBorder.h
<http://git.reviewboard.kde.org/r/111044/#comment25839>

    I would move that a line down. Should there not also be a setOuterBorderWidth to set the value?



libs/odf/KoBorder.cpp
<http://git.reviewboard.kde.org/r/111044/#comment25840>

    This seems to miss handling cases there only the specialBorderString is set. 


- Thorsten Zachmann


On June 22, 2013, 6:28 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111044/
> -----------------------------------------------------------
> 
> (Updated June 22, 2013, 6:28 a.m.)
> 
> 
> Review request for Calligra, C. Boemann, Boudewijn Rempt, and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> This patch implements loading, saving and painting of borders for shapes in general. It also implements calls to actually paint borders in particular for the picture shape and text shape.
> 
> At the same time I moved border painting from KWCanvasBase to KoBorder, which I announced some weeks ago that I wanted to do.
> 
> A patch this deep in the libraries should not go in without a run of cstester. I would be glad for help with this since I only have a semi-weak laptop.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShape.h fe6cc3f 
>   libs/flake/KoShape.cpp 6d14a8c 
>   libs/flake/KoShape_p.h aa6633c 
>   libs/odf/KoBorder.h bdbf86e 
>   libs/odf/KoBorder.cpp 58f8e45 
>   plugins/pictureshape/PictureShape.cpp 976fadd 
>   plugins/textshape/TextShape.cpp b230f0a 
>   words/part/KWCanvasBase.cpp 7d12890 
> 
> Diff: http://git.reviewboard.kde.org/r/111044/diff/
> 
> 
> Testing
> -------
> 
> Tested with all the files with the string "border" in it in the test suite.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130629/7b6570a1/attachment.htm>