Review Request 108444: Fix cash on creating new character style

Pierre Stirnweiss pstirnweiss at googlemail.com
Fri Jan 18 14:09:12 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108444/
-----------------------------------------------------------

(Updated Jan. 18, 2013, 2:09 p.m.)


Review request for Calligra and Friedrich W. H. Kossebau.


Changes
-------

Fixed also the multiple creation of style with same name


Description
-------

When creating a new character style, Words crashed because an null pointer was passed around and used. Also, the name of the style was not updated.


This addresses bug 313233.
    http://bugs.kde.org/show_bug.cgi?id=313233


Diffs (updated)
-----

  plugins/textshape/dialogs/CharacterGeneral.cpp d3eead6 
  plugins/textshape/dialogs/FormattingPreview.cpp 1ed3b83 
  plugins/textshape/dialogs/StyleManager.h a45a58a 
  plugins/textshape/dialogs/StyleManager.cpp c561d35 
  plugins/textshape/dialogs/StylesModel.cpp 80ea48d 

Diff: http://git.reviewboard.kde.org/r/108444/diff/


Testing
-------


Thanks,

Pierre Stirnweiss

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130118/6950c885/attachment.htm>


More information about the calligra-devel mailing list