Review Request 108444: Fix cash on creating new character style

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108444/#review25756
-----------------------------------------------------------

Ship it!


Works for me now, no crashes and very strange behaviour seen, good work, please commit after fixing the one issue mentioned!


plugins/textshape/dialogs/StyleManager.cpp
<http://git.reviewboard.kde.org/r/108444/#comment19598>

    Looks like the first line should just be
        KoCharacterStyle *newStyle;
    right?
    Because in the if/else branches following the same stuff happens (and more). so the styles created in the first line will leak.
    
    


- Friedrich W. H. Kossebau


On Jan. 18, 2013, 2:09 p.m., Pierre Stirnweiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108444/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 2:09 p.m.)
> 
> 
> Review request for Calligra and Friedrich W. H. Kossebau.
> 
> 
> Description
> -------
> 
> When creating a new character style, Words crashed because an null pointer was passed around and used. Also, the name of the style was not updated.
> 
> 
> This addresses bug 313233.
>     http://bugs.kde.org/show_bug.cgi?id=313233
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/dialogs/CharacterGeneral.cpp d3eead6 
>   plugins/textshape/dialogs/FormattingPreview.cpp 1ed3b83 
>   plugins/textshape/dialogs/StyleManager.h a45a58a 
>   plugins/textshape/dialogs/StyleManager.cpp c561d35 
>   plugins/textshape/dialogs/StylesModel.cpp 80ea48d 
> 
> Diff: http://git.reviewboard.kde.org/r/108444/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pierre Stirnweiss
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130118/a943cfd1/attachment.htm>